GTK: First draft of using native themes, partially based on evan's CL 118358.

GTK: Initial implementation of using GTK themes, partially based on evan's CL 118358.

A lot of stuff works:
- Colors are picked out of the GTK theme.
- Buttons use the current GTK button theme.
- We use the user's icon theme.

A lot of stuff doesn't:
- We could do a better job of picking colors for the skylines.
- The omnibox hasn't been touched.
- UI that's not part of the toolbar hasn't been touched.
- We currently fail on themes like HighContrastInverse.

TEST=Under Options>Personal Stuff, click GTK Theme. Colors and widgets should be rendered with the current GTK theme stuff.
TEST=With chrome open and in GTK Theme mode, change your GTK theme or icon theme. chrome should pick up on the change immediately and reimport the colors and images. 
http://crbug.com/13967

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19868

[James Hawkins, 2009-07-01 21:22:31]

lg on my end.

[Evan Martin, 2009-07-01 21:55:35]

maybe tony is a good reviewer?

[Glen Murphy, 2009-07-02 00:16:20]

non-GTK code LGTM

[Glen Murphy, 2009-07-02 00:31:47]

gtk_theme_provider also LG with one note.

http://codereview.chromium.org/150176/diff/125/141
File chrome/browser/gtk/gtk_theme_provider.cc (right):

http://codereview.chromium.org/150176/diff/125/141#newcode73
Line 73: SkCanvas canvas(*bitmap);
You can use bitmap->eraseARGB(a, r, g, b) to fill a bitmap with a single color.

[Elliot Glaysher, 2009-07-02 00:55:13]

ping tony or evan for review.

[Elliot Glaysher, 2009-07-02 20:11:28]

@estade:
> 2. I think the custom button gtk paint changes will break the manual
> paint state stuff when using the system theme, no?

I don't understand. Clicking on the menu button keeps it depressed, even in
system rendering mode.

[Evan Stade, 2009-07-02 20:13:55]

On 2009/07/02 20:11:28, Elliot Glaysher wrote:
> @estade:
> > 2. I think the custom button gtk paint changes will break the manual
> > paint state stuff when using the system theme, no?
> 
> I don't understand. Clicking on the menu button keeps it depressed, even in
> system rendering mode.

ok then I'm wrong.

[Evan Stade, 2009-07-02 20:16:58]

LGTM

[tony, 2009-07-07 19:47:05]

Some late nits.  Feel free to ignore them.

http://codereview.chromium.org/150176/diff/2001/3003
File chrome/browser/browser_theme_provider.h (right):

http://codereview.chromium.org/150176/diff/2001/3003#newcode23
Line 23: namespace themes {
:( The style guide says the namespaces name should be chrome_browser. 
Alternately you could just make these class statics in BrowserThemeProvider
which might get rid of the need to prefix them in GtkThemeProvider.

http://codereview.chromium.org/150176/diff/2001/3024
File chrome/browser/profile.cc (right):

http://codereview.chromium.org/150176/diff/2001/3024#newcode937
Line 937: scoped_refptr<BrowserThemeProvider> themes(new GtkThemeProvider);
Nit: Maybe make a static ::Create method to avoid this #if?

http://codereview.chromium.org/150176/diff/2001/3027
File chrome/common/pref_names.cc (right):

http://codereview.chromium.org/150176/diff/2001/3027#newcode252
Line 252: #if defined(OS_LINUX)
same thing about #if.

http://codereview.chromium.org/150176/diff/2001/3028
File chrome/common/pref_names.h (right):

http://codereview.chromium.org/150176/diff/2001/3028#newcode94
Line 94: #if defined(OS_LINUX)
Nit: I would probably not bother with putting platform specific prefs behind
#ifs.  In theory if it's not used on a platform, the linker will drop it.