Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Side by Side Diff: chrome/app/chrome_dll_main.cc

Issue 150176: GTK: First draft of using native themes, partially based on evan's CL 118358. (Closed)
Patch Set: And the codereview tool is back. Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // TODO(port): the ifdefs in here are a first step towards trying to determine 5 // TODO(port): the ifdefs in here are a first step towards trying to determine
6 // the correct abstraction for all the OS functionality required at this 6 // the correct abstraction for all the OS functionality required at this
7 // stage of process initialization. It should not be taken as a final 7 // stage of process initialization. It should not be taken as a final
8 // abstraction. 8 // abstraction.
9 9
10 #include "build/build_config.h" 10 #include "build/build_config.h"
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 strstr(message, "wrong ELF class: ELFCLASS64")) { 169 strstr(message, "wrong ELF class: ELFCLASS64")) {
170 // http://crbug.com/9643 170 // http://crbug.com/9643
171 // Until we have a real 64-bit build or all of these 32-bit package issues 171 // Until we have a real 64-bit build or all of these 32-bit package issues
172 // are sorted out, don't fatal on ELF 32/64-bit mismatch warnings. 172 // are sorted out, don't fatal on ELF 32/64-bit mismatch warnings.
173 LOG(ERROR) << "Bug 9643: " << log_domain << ": " << message; 173 LOG(ERROR) << "Bug 9643: " << log_domain << ": " << message;
174 } else if (strstr(message, "gtk_widget_size_allocate(): attempt to " 174 } else if (strstr(message, "gtk_widget_size_allocate(): attempt to "
175 "allocate widget with width") && 175 "allocate widget with width") &&
176 !GTK_CHECK_VERSION(2, 16, 1)) { 176 !GTK_CHECK_VERSION(2, 16, 1)) {
177 // http://crbug.com/11133 177 // http://crbug.com/11133
178 LOG(ERROR) << "Bug 11133"; 178 LOG(ERROR) << "Bug 11133";
179 } else if (strstr(message, "Theme file for default has no") ||
180 strstr(message, "Theme directory")) {
181 LOG(ERROR) << "GTK theme error: " << message;
179 } else { 182 } else {
180 #ifdef NDEBUG 183 #ifdef NDEBUG
181 LOG(ERROR) << log_domain << ": " << message; 184 LOG(ERROR) << log_domain << ": " << message;
182 #else 185 #else
183 LOG(FATAL) << log_domain << ": " << message; 186 LOG(FATAL) << log_domain << ": " << message;
184 #endif 187 #endif
185 } 188 }
186 } 189 }
187 190
188 static void SetUpGLibLogHandler() { 191 static void SetUpGLibLogHandler() {
(...skipping 332 matching lines...) Expand 10 before | Expand all | Expand 10 after
521 _CrtDumpMemoryLeaks(); 524 _CrtDumpMemoryLeaks();
522 #endif // _CRTDBG_MAP_ALLOC 525 #endif // _CRTDBG_MAP_ALLOC
523 526
524 _Module.Term(); 527 _Module.Term();
525 #endif 528 #endif
526 529
527 logging::CleanupChromeLogging(); 530 logging::CleanupChromeLogging();
528 531
529 return rv; 532 return rv;
530 } 533 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/browser_theme_provider.h » ('j') | chrome/browser/browser_theme_provider.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698