chrome/app/chrome_dll_main.cc - Issue 150176: GTK: First draft of using native themes, partially based on evan's CL 118358.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/chrome_dll_main.cc

Issue 150176: GTK: First draft of using native themes, partially based on evan's CL 118358. (Closed)

Patch Set: And the codereview tool is back. Created 11 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/app/chrome_dll_main.cc

diff --git a/chrome/app/chrome_dll_main.cc b/chrome/app/chrome_dll_main.cc

index de4d82297564f2a40afa80c2402badced7cfad4f..213a40f2cd438f32820d9b87288811b9175a9c8b 100644

--- a/chrome/app/chrome_dll_main.cc

+++ b/chrome/app/chrome_dll_main.cc

@@ -176,6 +176,9 @@ static void GLibLogHandler(const gchar* log_domain,

!GTK_CHECK_VERSION(2, 16, 1)) {

// http://crbug.com/11133

LOG(ERROR) << "Bug 11133";

+ } else if (strstr(message, "Theme file for default has no") ||

+ strstr(message, "Theme directory")) {

+ LOG(ERROR) << "GTK theme error: " << message;

} else {

#ifdef NDEBUG

LOG(ERROR) << log_domain << ": " << message;