Issue 150095: Fix: Spurious SQL error message is logged in priming SQLite database cache....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 150095: Fix: Spurious SQL error message is logged in priming SQLite database cache.... (Closed)

Created:
11 years, 5 months ago by Yuzo

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews_googlegroups.com, darin (slow to review), Ben Goodger (Google), willchan no longer on Chromium, Peter Kasting

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Fix: Spurious SQL error message is logged in priming SQLite database cache. This patch depends on the MetaTableHelper refactoring in: http://codereview.chromium.org/150094 Currently, a spurious SQL error message is logged every time a unit test that access SQLite database runs. Example: [----------] 6 tests from HistoryBackendTest [ RUN ] HistoryBackendTest.Loaded [5660:5304:0630/150705:414864129:ERROR:sqlite_utils.cc(204)] SQLStatement.prepare_v2 failed: no such table: meta BUG=none TEST=n/a Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19803

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -35 lines)			Patch
M	chrome/browser/history/history_database.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/history/history_database.cc	View	2 chunks	+2 lines, -15 lines	0 comments	Download
M	chrome/common/net/cookie_monster_sqlite.cc	View	2 chunks	+1 line, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yuzo

Hi, Peter, Can you review also this? This depends on http://codereview.chromium.org/150094 . Please reassign either/both ...

11 years, 5 months ago (2009-06-30 09:48:02 UTC) #1

Yuzo

Hi, Mac-Antoine, Can you review also this? This depends on http://codereview.chromium.org/150094 Yuzo

11 years, 5 months ago (2009-07-01 07:54:02 UTC) #2

lgtm

Expand Messages | Collapse Messages