Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2574)

Unified Diff: chrome/common/net/cookie_monster_sqlite.cc

Issue 150095: Fix: Spurious SQL error message is logged in priming SQLite database cache.... (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/src/
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_database.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/net/cookie_monster_sqlite.cc
===================================================================
--- chrome/common/net/cookie_monster_sqlite.cc (revision 19238)
+++ chrome/common/net/cookie_monster_sqlite.cc (working copy)
@@ -303,19 +303,6 @@
return true;
}
-void PrimeCache(sqlite3* db) {
- // A statement must be open for the preload command to work. If the meta
- // table can't be read, it probably means this is a new database and there
- // is nothing to preload (so it's OK we do nothing).
- SQLStatement dummy;
- if (dummy.prepare(db, "SELECT * from meta") != SQLITE_OK)
- return;
- if (dummy.step() != SQLITE_ROW)
- return;
-
- sqlite3Preload(db);
-}
-
} // namespace
bool SQLitePersistentCookieStore::Load(
@@ -333,7 +320,7 @@
return false;
}
- PrimeCache(db);
+ MetaTableHelper::PrimeCache(std::string(), db);
// Slurp all the cookies into the out-vector.
SQLStatement smt;
« no previous file with comments | « chrome/browser/history/history_database.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698