Issue 150094: Refactor MetaTableHelper to remove redundant table name prefixing with databa...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 150094: Refactor MetaTableHelper to remove redundant table name prefixing with databa... (Closed)

Created:
11 years, 5 months ago by Yuzo

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews_googlegroups.com, Dean McNamee

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Refactor MetaTableHelper to remove redundant table name prefixing with database name. Also, PrimeCache logic duplicated in HistoryBackend and SQLitePersistentCookieStore is moved to this class. BUG=none TEST=n/a

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -17 lines)			Patch
M	chrome/browser/meta_table_helper.h	View	1	2 chunks	+11 lines, -0 lines	1 comment	Download
M	chrome/browser/meta_table_helper.cc	View	1	4 chunks	+35 lines, -17 lines	0 comments	Download
A	chrome/browser/meta_table_helper_unittest.cc	View		1 chunk	+28 lines, -0 lines	0 comments	Download
M	chrome/chrome.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

I've seen PrimeCache() in src/chrome/common/net/cookie_monster_sqlite.cc, could you change it at the same time to use ...

11 years, 5 months ago (2009-07-01 10:59:34 UTC) #3

M-A Ruel

Err.. ok I should have looked at the other review first since you do remove ...

11 years, 5 months ago (2009-07-01 11:01:21 UTC) #4

Yuzo

11 years, 5 months ago (2009-07-02 07:44:13 UTC) #5

On 2009/07/01 11:01:21, Marc-Antoine Ruel wrote:
> Err.. ok I should have looked at the other review first since you do remove
> PrimeCache there.
> 
> Ignore my prior comment and lgtm

Submitted as r19802.

Expand Messages | Collapse Messages