Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Issue 149622: Backing out r20493 (http://codereview.chromium.org/149492), as it inadvertent... (Closed)

Created:
11 years, 5 months ago by Avi (use Gerrit)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, John Grabowski, Ben Goodger (Google), Scott Hess - ex-Googler
Visibility:
Public.

Description

Backing out r20493 (http://codereview.chromium.org/149492), as it inadvertently killed the Omnibox suggestion list. BUG=http://crbug.com/16714 TEST=Type in the omnibox; you should get a suggestion list. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20642

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_mac.mm View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Avi (use Gerrit)
11 years, 5 months ago (2009-07-14 18:45:33 UTC) #1
pink (ping after 24hrs)
11 years, 5 months ago (2009-07-14 18:46:52 UTC) #2
LGTM :-(

Powered by Google App Engine
This is Rietveld 408576698