chrome/browser/autocomplete/autocomplete_edit_view_mac.mm - Issue 149622: Backing out r20493 (http://codereview.chromium.org/149492), as it inadvertent...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

Issue 149622: Backing out r20493 (http://codereview.chromium.org/149492), as it inadvertent... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 11 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

===================================================================

--- chrome/browser/autocomplete/autocomplete_edit_view_mac.mm (revision 20621)

+++ chrome/browser/autocomplete/autocomplete_edit_view_mac.mm (working copy)

@@ -549,8 +549,13 @@

}

void AutocompleteEditViewMac::FocusLocation() {

- [[field_ window] makeFirstResponder:field_];

- DCHECK_EQ([field_ currentEditor], [[field_ window] firstResponder]);

+ // -makeFirstResponder: will select the entire field_. If we're

+ // already firstResponder, it's likely that we want to retain the

+ // current selection.

+ if (![field_ currentEditor]) {

+ [[field_ window] makeFirstResponder:field_];

+ DCHECK_EQ([field_ currentEditor], [[field_ window] firstResponder]);

+ }

}

@implementation AutocompleteFieldDelegate

« no previous file with comments | « chrome/browser/autocomplete/autocomplete_edit_view_mac.h ('k') | no next file » | no next file with comments »