Issue 149492: [Mac] Remove guard on FocusLocation() in autocomplete field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149492: [Mac] Remove guard on FocusLocation() in autocomplete field. (Closed)

Created:
11 years, 5 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

[Mac] Remove guard on FocusLocation() in autocomplete field. I went auditing around, and AFAICT all remaining callers should be fine with selecting everything. http://crbug.com/12246 TEST=Type some stuff in address bar. With cursor in bar, Command-l should select all.

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -8 lines)			Patch
	M	chrome/browser/autocomplete/autocomplete_edit_view_mac.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/autocomplete/autocomplete_edit_view_mac.mm	View		1 chunk	+2 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

11 years, 5 months ago (2009-07-14 20:15:11 UTC) #3

On 2009/07/13 15:03:30, Avi wrote:
> LGTM

Reverted in r20642; broke the omnibox list.

Expand Messages | Collapse Messages