Issue 149392: Skip the write barrier for global property cell writes. The heap...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149392: Skip the write barrier for global property cell writes. The heap... (Closed)

Created:
11 years, 5 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Skip the write barrier for global property cell writes. The heap verification code was refactored to avoid verifying that property cells have correct remembered sets. Committed: http://code.google.com/p/v8/source/detail?r=2423

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+111 lines, -161 lines)			Patch
M	src/arm/stub-cache-arm.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/heap.cc	View	1 chunk	+13 lines, -5 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+10 lines, -1 line	0 comments	Download
M	src/spaces.h	View	8 chunks	+17 lines, -15 lines	0 comments	Download
M	src/spaces.cc	View	3 chunks	+71 lines, -133 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages