Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Side by Side Diff: src/heap.cc

Issue 149392: Skip the write barrier for global property cell writes. The heap... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2750 matching lines...) Expand 10 before | Expand all | Expand 10 after
2761 2761
2762 return false; 2762 return false;
2763 } 2763 }
2764 2764
2765 2765
2766 #ifdef DEBUG 2766 #ifdef DEBUG
2767 void Heap::Verify() { 2767 void Heap::Verify() {
2768 ASSERT(HasBeenSetup()); 2768 ASSERT(HasBeenSetup());
2769 2769
2770 VerifyPointersVisitor visitor; 2770 VerifyPointersVisitor visitor;
2771 Heap::IterateRoots(&visitor); 2771 IterateRoots(&visitor);
2772 2772
2773 AllSpaces spaces; 2773 new_space_.Verify();
2774 while (Space* space = spaces.next()) { 2774
2775 space->Verify(); 2775 VerifyPointersAndRSetVisitor rset_visitor;
2776 } 2776 old_pointer_space_->Verify(&rset_visitor);
2777 map_space_->Verify(&rset_visitor);
2778
2779 VerifyPointersVisitor no_rset_visitor;
2780 old_data_space_->Verify(&no_rset_visitor);
2781 code_space_->Verify(&no_rset_visitor);
2782 cell_space_->Verify(&no_rset_visitor);
2783
2784 lo_space_->Verify();
2777 } 2785 }
2778 #endif // DEBUG 2786 #endif // DEBUG
2779 2787
2780 2788
2781 Object* Heap::LookupSymbol(Vector<const char> string) { 2789 Object* Heap::LookupSymbol(Vector<const char> string) {
2782 Object* symbol = NULL; 2790 Object* symbol = NULL;
2783 Object* new_table = symbol_table()->LookupSymbol(string, &symbol); 2791 Object* new_table = symbol_table()->LookupSymbol(string, &symbol);
2784 if (new_table->IsFailure()) return new_table; 2792 if (new_table->IsFailure()) return new_table;
2785 // Can't use set_symbol_table because SymbolTable::cast knows that 2793 // Can't use set_symbol_table because SymbolTable::cast knows that
2786 // SymbolTable is a singleton and checks for identity. 2794 // SymbolTable is a singleton and checks for identity.
(...skipping 895 matching lines...) Expand 10 before | Expand all | Expand 10 after
3682 #ifdef DEBUG 3690 #ifdef DEBUG
3683 bool Heap::GarbageCollectionGreedyCheck() { 3691 bool Heap::GarbageCollectionGreedyCheck() {
3684 ASSERT(FLAG_gc_greedy); 3692 ASSERT(FLAG_gc_greedy);
3685 if (Bootstrapper::IsActive()) return true; 3693 if (Bootstrapper::IsActive()) return true;
3686 if (disallow_allocation_failure()) return true; 3694 if (disallow_allocation_failure()) return true;
3687 return CollectGarbage(0, NEW_SPACE); 3695 return CollectGarbage(0, NEW_SPACE);
3688 } 3696 }
3689 #endif 3697 #endif
3690 3698
3691 } } // namespace v8::internal 3699 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698