Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/arm/stub-cache-arm.cc

Issue 149392: Skip the write barrier for global property cell writes. The heap... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/heap.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2006-2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 895 matching lines...) Expand 10 before | Expand all | Expand 10 after
906 906
907 // Check that the map of the global has not changed. 907 // Check that the map of the global has not changed.
908 __ ldr(r1, MemOperand(sp, 0 * kPointerSize)); 908 __ ldr(r1, MemOperand(sp, 0 * kPointerSize));
909 __ ldr(r3, FieldMemOperand(r1, HeapObject::kMapOffset)); 909 __ ldr(r3, FieldMemOperand(r1, HeapObject::kMapOffset));
910 __ cmp(r3, Operand(Handle<Map>(object->map()))); 910 __ cmp(r3, Operand(Handle<Map>(object->map())));
911 __ b(ne, &miss); 911 __ b(ne, &miss);
912 912
913 // Store the value in the cell. 913 // Store the value in the cell.
914 __ mov(r2, Operand(Handle<JSGlobalPropertyCell>(cell))); 914 __ mov(r2, Operand(Handle<JSGlobalPropertyCell>(cell)));
915 __ str(r0, FieldMemOperand(r2, JSGlobalPropertyCell::kValueOffset)); 915 __ str(r0, FieldMemOperand(r2, JSGlobalPropertyCell::kValueOffset));
916 __ mov(r1, Operand(JSGlobalPropertyCell::kValueOffset));
917 __ RecordWrite(r2, r1, r3);
918 916
919 __ Ret(); 917 __ Ret();
920 918
921 // Handle store cache miss. 919 // Handle store cache miss.
922 __ bind(&miss); 920 __ bind(&miss);
923 __ DecrementCounter(&Counters::named_store_global_inline, 1, r1, r3); 921 __ DecrementCounter(&Counters::named_store_global_inline, 1, r1, r3);
924 __ IncrementCounter(&Counters::named_store_global_inline_miss, 1, r1, r3); 922 __ IncrementCounter(&Counters::named_store_global_inline_miss, 1, r1, r3);
925 Handle<Code> ic(Builtins::builtin(Builtins::StoreIC_Miss)); 923 Handle<Code> ic(Builtins::builtin(Builtins::StoreIC_Miss));
926 __ Jump(ic, RelocInfo::CODE_TARGET); 924 __ Jump(ic, RelocInfo::CODE_TARGET);
927 925
(...skipping 356 matching lines...) Expand 10 before | Expand all | Expand 10 after
1284 __ Jump(ic, RelocInfo::CODE_TARGET); 1282 __ Jump(ic, RelocInfo::CODE_TARGET);
1285 1283
1286 // Return the generated code. 1284 // Return the generated code.
1287 return GetCode(transition == NULL ? FIELD : MAP_TRANSITION, name); 1285 return GetCode(transition == NULL ? FIELD : MAP_TRANSITION, name);
1288 } 1286 }
1289 1287
1290 1288
1291 #undef __ 1289 #undef __
1292 1290
1293 } } // namespace v8::internal 1291 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698