Issue 149261: Disimiss JS message boxes when an interstitial is showing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149261: Disimiss JS message boxes when an interstitial is showing (Closed)

Created:
11 years, 5 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

This CL makes sure JavaScript alerts are not shown while an interstitial is showing. (The interstitial is displayed on top of an existing page. We don't want the hidden page to interfere with the interstitial.) BUG=http://crbug.com/3256 TEST=Open the page attached in the bug (interstitial_test.html), no alert boxes should show. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20084

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -3 lines)			Patch
M	chrome/browser/tab_contents/tab_contents.h	View		2 chunks	+3 lines, -2 lines	1 comment	Download
M	chrome/browser/tab_contents/tab_contents.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/web_contents_unittest.cc	View	1	2 chunks	+34 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

11 years, 5 months ago (2009-07-07 20:01:49 UTC) #2

LGTM

http://codereview.chromium.org/149261/diff/7/1006
File chrome/browser/tab_contents/tab_contents.h (right):

http://codereview.chromium.org/149261/diff/7/1006#newcode284
Line 284: // NOTE: If you override \this, call the superclass version too!
Typo?

Expand Messages | Collapse Messages