Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Side by Side Diff: chrome/browser/tab_contents/tab_contents.h

Issue 149261: Disimiss JS message boxes when an interstitial is showing (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/tab_contents/tab_contents.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_TAB_CONTENTS_TAB_CONTENTS_H_ 5 #ifndef CHROME_BROWSER_TAB_CONTENTS_TAB_CONTENTS_H_
6 #define CHROME_BROWSER_TAB_CONTENTS_TAB_CONTENTS_H_ 6 #define CHROME_BROWSER_TAB_CONTENTS_TAB_CONTENTS_H_
7 7
8 #include "build/build_config.h" 8 #include "build/build_config.h"
9 9
10 #include <map> 10 #include <map>
(...skipping 263 matching lines...) Expand 10 before | Expand all | Expand 10 after
274 274
275 // Convenience method for notifying the delegate of a navigation state 275 // Convenience method for notifying the delegate of a navigation state
276 // change. See TabContentsDelegate. 276 // change. See TabContentsDelegate.
277 void NotifyNavigationStateChanged(unsigned changed_flags); 277 void NotifyNavigationStateChanged(unsigned changed_flags);
278 278
279 // Invoked when the tab contents becomes selected. If you override, be sure 279 // Invoked when the tab contents becomes selected. If you override, be sure
280 // and invoke super's implementation. 280 // and invoke super's implementation.
281 virtual void DidBecomeSelected(); 281 virtual void DidBecomeSelected();
282 282
283 // Invoked when the tab contents becomes hidden. 283 // Invoked when the tab contents becomes hidden.
284 // NOTE: If you override this, call the superclass version too! 284 // NOTE: If you override \this, call the superclass version too!
brettw 2009/07/07 20:01:50 Typo?
285 virtual void WasHidden(); 285 virtual void WasHidden();
286 286
287 // Activates this contents within its containing window, bringing that window 287 // Activates this contents within its containing window, bringing that window
288 // to the foreground if necessary. 288 // to the foreground if necessary.
289 void Activate(); 289 void Activate();
290 290
291 // TODO(brettw) document these. 291 // TODO(brettw) document these.
292 virtual void ShowContents(); 292 virtual void ShowContents();
293 virtual void HideContents(); 293 virtual void HideContents();
294 294
(...skipping 276 matching lines...) Expand 10 before | Expand all | Expand 10 after
571 } 571 }
572 572
573 private: 573 private:
574 friend class NavigationController; 574 friend class NavigationController;
575 // Used to access the child_windows_ (ConstrainedWindowList) for testing 575 // Used to access the child_windows_ (ConstrainedWindowList) for testing
576 // automation purposes. 576 // automation purposes.
577 friend class AutomationProvider; 577 friend class AutomationProvider;
578 friend class BlockedPopupContainerTest; 578 friend class BlockedPopupContainerTest;
579 friend class BlockedPopupContainerControllerTest; 579 friend class BlockedPopupContainerControllerTest;
580 580
581 FRIEND_TEST(BlockedPopupContainerTest, TestReposition);
582 FRIEND_TEST(TabContentsTest, NoJSMessageOnInterstitials);
581 FRIEND_TEST(TabContentsTest, UpdateTitle); 583 FRIEND_TEST(TabContentsTest, UpdateTitle);
582 FRIEND_TEST(BlockedPopupContainerTest, TestReposition);
583 584
584 // Temporary until the view/contents separation is complete. 585 // Temporary until the view/contents separation is complete.
585 friend class TabContentsView; 586 friend class TabContentsView;
586 #if defined(OS_WIN) 587 #if defined(OS_WIN)
587 friend class TabContentsViewWin; 588 friend class TabContentsViewWin;
588 #elif defined(OS_MACOSX) 589 #elif defined(OS_MACOSX)
589 friend class TabContentsViewMac; 590 friend class TabContentsViewMac;
590 #elif defined(OS_LINUX) 591 #elif defined(OS_LINUX)
591 friend class TabContentsViewGtk; 592 friend class TabContentsViewGtk;
592 #endif 593 #endif
(...skipping 490 matching lines...) Expand 10 before | Expand all | Expand 10 after
1083 // True if the user has decided to block future javascript messages. This is 1084 // True if the user has decided to block future javascript messages. This is
1084 // reset on navigations to false on navigations. 1085 // reset on navigations to false on navigations.
1085 bool suppress_javascript_messages_; 1086 bool suppress_javascript_messages_;
1086 1087
1087 // --------------------------------------------------------------------------- 1088 // ---------------------------------------------------------------------------
1088 1089
1089 DISALLOW_COPY_AND_ASSIGN(TabContents); 1090 DISALLOW_COPY_AND_ASSIGN(TabContents);
1090 }; 1091 };
1091 1092
1092 #endif // CHROME_BROWSER_TAB_CONTENTS_TAB_CONTENTS_H_ 1093 #endif // CHROME_BROWSER_TAB_CONTENTS_TAB_CONTENTS_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/tab_contents/tab_contents.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698