Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: chrome/browser/tab_contents/tab_contents.h

Issue 149261: Disimiss JS message boxes when an interstitial is showing (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/tab_contents/tab_contents.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/tab_contents.h
===================================================================
--- chrome/browser/tab_contents/tab_contents.h (revision 20029)
+++ chrome/browser/tab_contents/tab_contents.h (working copy)
@@ -281,7 +281,7 @@
virtual void DidBecomeSelected();
// Invoked when the tab contents becomes hidden.
- // NOTE: If you override this, call the superclass version too!
+ // NOTE: If you override \this, call the superclass version too!
brettw 2009/07/07 20:01:50 Typo?
virtual void WasHidden();
// Activates this contents within its containing window, bringing that window
@@ -578,8 +578,9 @@
friend class BlockedPopupContainerTest;
friend class BlockedPopupContainerControllerTest;
+ FRIEND_TEST(BlockedPopupContainerTest, TestReposition);
+ FRIEND_TEST(TabContentsTest, NoJSMessageOnInterstitials);
FRIEND_TEST(TabContentsTest, UpdateTitle);
- FRIEND_TEST(BlockedPopupContainerTest, TestReposition);
// Temporary until the view/contents separation is complete.
friend class TabContentsView;
« no previous file with comments | « no previous file | chrome/browser/tab_contents/tab_contents.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698