Issue 149199: DevTools: Preserve devtools window contents on dock/undock.

Issue 149199: DevTools: Preserve devtools window contents on dock/undock. (Closed)

Created:
11 years, 5 months ago by pfeldman

Modified:
9 years, 7 months ago

Reviewers:
yurys

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

DevTools: Preserve devtools window contents on dock/undock. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20016

Patch Set 4 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+178 lines, -208 lines)			Patch
M	chrome/browser/debugger/devtools_manager.cc	View	1	2 chunks	+2 lines, -8 lines	0 comments	Download
M	chrome/browser/debugger/devtools_window.h	View	1 2 3	2 chunks	+48 lines, -23 lines	0 comments	Download
M	chrome/browser/debugger/devtools_window.cc	View	1 2 3	6 chunks	+128 lines, -177 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

yurys

LGTM http://codereview.chromium.org/149199/diff/1/2 File chrome/browser/debugger/devtools_manager.h (right): http://codereview.chromium.org/149199/diff/1/2#newcode83 Line 83: void OpenDevToolsWindow(RenderViewHost* inspected_rvh, this is not used ...

11 years, 5 months ago (2009-07-06 14:05:08 UTC) #2

pfeldman

11 years, 5 months ago (2009-07-06 14:15:05 UTC) #3

http://codereview.chromium.org/149199/diff/1005/1006
File chrome/browser/debugger/devtools_window.cc (right):

http://codereview.chromium.org/149199/diff/1005/1006#newcode56
Line 56: GURL url(std::string(chrome::kChromeUIDevToolsURL) + "devtools.html");
On 2009/07/06 14:05:09, Yury Semikhatsky wrote:
> consider extracting the code into Init method

I really don't want to be calling Init everywhere. Let me do it later if it
grows please.

http://codereview.chromium.org/149199/diff/1005/1006#newcode92
Line 92: delete tab_contents_;
On 2009/07/06 14:05:09, Yury Semikhatsky wrote:
> please comment why it's deleted only when devtools are docked

Done.

http://codereview.chromium.org/149199/diff/1005/1006#newcode92
Line 92: delete tab_contents_;
On 2009/07/06 14:05:09, Yury Semikhatsky wrote:
> tab_contents_ = NULL

Done.

http://codereview.chromium.org/149199/diff/1005/1006#newcode177
Line 177: //  browser_->AddTabContents(tab_contents_, NEW_FOREGROUND_TAB,
gfx::Rect(),
On 2009/07/06 14:05:09, Yury Semikhatsky wrote:
> remove commented code

Done.

http://codereview.chromium.org/149199/diff/1005/1006#newcode207
Line 207: NotifyCloseListener();
On 2009/07/06 14:05:09, Yury Semikhatsky wrote:
> ommenting when it may happen whould help to understand this code

Done.

Expand Messages | Collapse Messages