Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1935)

Unified Diff: chrome/browser/debugger/devtools_manager.cc

Issue 149199: DevTools: Preserve devtools window contents on dock/undock. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/debugger/devtools_window.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/debugger/devtools_manager.cc
===================================================================
--- chrome/browser/debugger/devtools_manager.cc (revision 19938)
+++ chrome/browser/debugger/devtools_manager.cc (working copy)
@@ -128,7 +128,7 @@
if (!host) {
bool docked = inspected_rvh->process()->profile()->GetPrefs()->
GetBoolean(prefs::kDevToolsOpenDocked);
- host = DevToolsWindow::CreateDevToolsWindow(
+ host = new DevToolsWindow(
inspected_rvh->site_instance()->browsing_instance()->profile(),
inspected_rvh,
docked);
@@ -277,11 +277,5 @@
DevToolsWindow* window = client_host->AsDevToolsWindow();
DCHECK(window);
- if (window->is_docked() == docked) {
- return;
- }
-
- SendDetachToAgent(inspected_rvh);
- UnregisterDevToolsClientHostFor(inspected_rvh);
- OpenDevToolsWindow(inspected_rvh);
+ window->SetDocked(docked);
}
« no previous file with comments | « no previous file | chrome/browser/debugger/devtools_window.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698