DevTools: Preserve devtools window contents on dock/undock.

chrome/browser/debugger/devtools_manager.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/debugger/devtools_manager.h"
 
 #include "base/message_loop.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/debugger/devtools_window.h"
 #include "chrome/browser/debugger/devtools_client_host.h"
@@ skipping 110 matching lines @@
 
 void DevToolsManager::UndockWindow(RenderViewHost* client_rvh) {
   ReopenWindow(client_rvh, false);
 }
 
 void DevToolsManager::OpenDevToolsWindow(RenderViewHost* inspected_rvh) {
   DevToolsClientHost* host = GetDevToolsClientHostFor(inspected_rvh);
   if (!host) {
     bool docked = inspected_rvh->process()->profile()->GetPrefs()->
         GetBoolean(prefs::kDevToolsOpenDocked);
-    host = DevToolsWindow::CreateDevToolsWindow(
+    host = new DevToolsWindow(
         inspected_rvh->site_instance()->browsing_instance()->profile(),
         inspected_rvh,
         docked);
     RegisterDevToolsClientHostFor(inspected_rvh, host);
   }
   DevToolsWindow* window = host->AsDevToolsWindow();
   if (window) {
     in_initial_show_ = true;
     window->Show();
     in_initial_show_ = false;
@@ skipping 128 matching lines @@
   if (!client_host) {
     return;
   }
   RenderViewHost* inspected_rvh = GetInspectedRenderViewHost(client_host);
   DCHECK(inspected_rvh);
   inspected_rvh->process()->profile()->GetPrefs()->SetBoolean(
       prefs::kDevToolsOpenDocked, docked);
 
   DevToolsWindow* window = client_host->AsDevToolsWindow();
   DCHECK(window);
-  if (window->is_docked() == docked) {
-    return;
-  }
-
-  SendDetachToAgent(inspected_rvh);
-  UnregisterDevToolsClientHostFor(inspected_rvh);
-  OpenDevToolsWindow(inspected_rvh);
+  window->SetDocked(docked);
 }