Issue 149013: Add DCHECKs to the states that should be entered only when the...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149013: Add DCHECKs to the states that should be entered only when the... (Closed)

Created:
11 years, 6 months ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
Paweł Hajdan Jr., ibrar

CC:
chromium-reviews_googlegroups.com, darin (slow to review), willchan no longer on Chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Add DCHECKs to the states that should be entered only when the previous state succeeded. R=ibrar,phajdan.jr BUG=http://crbug.com/4965 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19394

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	net/ftp/ftp_network_transaction.cc	View		3 chunks	+7 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

wtc

This is quite straightforward, so I added the DCHECKs myself. Please review.

11 years, 6 months ago (2009-06-25 17:38:29 UTC) #1

LGTM