Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: net/ftp/ftp_network_transaction.cc

Issue 149013: Add DCHECKs to the states that should be entered only when the... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/ftp/ftp_network_transaction.cc
===================================================================
--- net/ftp/ftp_network_transaction.cc (revision 19253)
+++ net/ftp/ftp_network_transaction.cc (working copy)
@@ -239,6 +239,7 @@
rv = DoCtrlConnectComplete(rv);
break;
case STATE_CTRL_READ:
+ DCHECK(rv == OK);
rv = DoCtrlRead();
break;
case STATE_CTRL_READ_COMPLETE:
@@ -281,19 +282,24 @@
rv = DoCtrlWriteSIZE();
break;
case STATE_CTRL_WRITE_CWD:
+ DCHECK(rv == OK);
rv = DoCtrlWriteCWD();
break;
case STATE_CTRL_WRITE_LIST:
+ DCHECK(rv == OK);
rv = DoCtrlWriteLIST();
break;
case STATE_CTRL_WRITE_MDTM:
+ DCHECK(rv == OK);
rv = DoCtrlWriteMDTM();
break;
case STATE_CTRL_WRITE_QUIT:
+ DCHECK(rv == OK);
rv = DoCtrlWriteQUIT();
break;
case STATE_DATA_RESOLVE_HOST:
+ DCHECK(rv == OK);
rv = DoDataResolveHost();
break;
case STATE_DATA_RESOLVE_HOST_COMPLETE:
@@ -307,6 +313,7 @@
rv = DoDataConnectComplete(rv);
break;
case STATE_DATA_READ:
+ DCHECK(rv == OK);
rv = DoDataRead();
break;
case STATE_DATA_READ_COMPLETE:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698