Add DCHECKs to the states that should be entered only when the...

net/ftp/ftp_network_transaction.cc

 // Copyright (c) 2008 The Chromium Authors. All rights reserved.  Use of this
 // source code is governed by a BSD-style license that can be found in the
 // LICENSE file.
 
 #include "net/ftp/ftp_network_transaction.h"
 
 #include "base/compiler_specific.h"
 #include "base/string_util.h"
 #include "net/base/connection_type_histograms.h"
 #include "net/base/net_errors.h"
@@ skipping 221 matching lines @@
         rv = DoCtrlResolveHostComplete(rv);
         break;
       case STATE_CTRL_CONNECT:
         DCHECK(rv == OK);
         rv = DoCtrlConnect();
         break;
       case STATE_CTRL_CONNECT_COMPLETE:
         rv = DoCtrlConnectComplete(rv);
         break;
       case STATE_CTRL_READ:
+        DCHECK(rv == OK);
         rv = DoCtrlRead();
         break;
       case STATE_CTRL_READ_COMPLETE:
         rv = DoCtrlReadComplete(rv);
         break;
       case STATE_CTRL_WRITE_USER:
         DCHECK(rv == OK);
         rv = DoCtrlWriteUSER();
         break;
       case STATE_CTRL_WRITE_PASS:
@@ skipping 22 matching lines @@
         break;
       case STATE_CTRL_WRITE_RETR:
         DCHECK(rv == OK);
         rv = DoCtrlWriteRETR();
         break;
       case STATE_CTRL_WRITE_SIZE:
         DCHECK(rv == OK);
         rv = DoCtrlWriteSIZE();
         break;
       case STATE_CTRL_WRITE_CWD:
+        DCHECK(rv == OK);
         rv = DoCtrlWriteCWD();
         break;
       case STATE_CTRL_WRITE_LIST:
+        DCHECK(rv == OK);
         rv = DoCtrlWriteLIST();
         break;
       case STATE_CTRL_WRITE_MDTM:
+        DCHECK(rv == OK);
         rv = DoCtrlWriteMDTM();
         break;
       case STATE_CTRL_WRITE_QUIT:
+        DCHECK(rv == OK);
         rv = DoCtrlWriteQUIT();
         break;
 
       case STATE_DATA_RESOLVE_HOST:
+        DCHECK(rv == OK);
         rv = DoDataResolveHost();
         break;
       case STATE_DATA_RESOLVE_HOST_COMPLETE:
         rv = DoDataResolveHostComplete(rv);
         break;
       case STATE_DATA_CONNECT:
         DCHECK(rv == OK);
         rv = DoDataConnect();
         break;
       case STATE_DATA_CONNECT_COMPLETE:
         rv = DoDataConnectComplete(rv);
         break;
       case STATE_DATA_READ:
+        DCHECK(rv == OK);
         rv = DoDataRead();
         break;
       case STATE_DATA_READ_COMPLETE:
         rv = DoDataReadComplete(rv);
         break;
       default:
         NOTREACHED() << "bad state";
         rv = ERR_FAILED;
         break;
     }
@@ skipping 555 matching lines @@
                             &io_callback_);
 }
 
 int FtpNetworkTransaction::DoDataReadComplete(int result) {
   DLOG(INFO) << read_data_buf_->data();  // The read_data_buf_ is NULL
                                          // terminated string.
   return result;
 }
 
 }  // namespace net