Pass through non-character codepoints in UTF-8,16,32 and Wide conversion func...

Pass through non-character codepoints in UTF-8,16,32 and Wide conversion functions. 

They're structurally valid code points unlike malformed byte/surrogate sequences. I believe it's better to leave them
alone in conversion functions. 

This CL was triggered by file_util_unittest failure on Linux/Mac with my upcoming change 
to file_util::ReplaceIllegalCharacters (a part of http://codereview.chromium.org/126223 ). 

In addition, the upper bound for the output length in CodepageToWide was tightened. 

TEST=pass string_util and file_util unittests
BUG=NONE



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19132

[brettw, 2009-06-23 20:49:41]

http://codereview.chromium.org/147038/diff/1005/1007
File base/string_util.h (right):

http://codereview.chromium.org/147038/diff/1005/1007#newcode251
Line 251: #if 0
Why did you add these?

[jungshik at Google, 2009-06-23 21:51:00]

On 2009/06/23 20:49:41, brettw wrote:
> http://codereview.chromium.org/147038/diff/1005/1007
> File base/string_util.h (right):
> 
> http://codereview.chromium.org/147038/diff/1005/1007#newcode251
> Line 251: #if 0
> Why did you add these?

Ooops.by mistake :-). I'll get rid of it.

[Avi (use Gerrit), 2009-06-23 22:09:47]

http://codereview.chromium.org/147038/diff/1012/24
File base/string_util.h (right):

http://codereview.chromium.org/147038/diff/1012/24#newcode189
Line 189: // Note that only the structural validity is checked and 
non-character
double space

[brettw, 2009-06-23 22:26:55]

LGTM with these comment formatting and all the previous suggestions fixed.

http://codereview.chromium.org/147038/diff/1005/1007
File base/string_util.h (right):

http://codereview.chromium.org/147038/diff/1005/1007#newcode189
Line 189: // Note that only the structural validity is checked and 
non-character
Can you put an empty comment line here? I find this hard to follow without some
vertical space.

http://codereview.chromium.org/147038/diff/1005/1007#newcode279
Line 279: // Note that IsStringUTF8 checks not only if the input is structrually
Can you also put a "//" line above this one?

http://codereview.chromium.org/147038/diff/1005/1008
File base/string_util_icu.cc (right):

http://codereview.chromium.org/147038/diff/1005/1008#newcode446
Line 446: // Moreover, non-BMP characters in legacy multibyte encodings
Blank line here?

[jungshik at Google, 2009-06-23 23:02:43]

On 2009/06/23 22:26:55, brettw wrote:
> LGTM with these comment formatting and all the previous suggestions fixed.

Thank you for taking a look. All the suggestions were about comment formatting
changes (which I addressed in the patch set I've just updated). Is there
anything I missed?


> 
> http://codereview.chromium.org/147038/diff/1005/1007
> File base/string_util.h (right):
> 
> http://codereview.chromium.org/147038/diff/1005/1007#newcode189
> Line 189: // Note that only the structural validity is checked and 
> non-character
> Can you put an empty comment line here? I find this hard to follow without
some
> vertical space.
> 
> http://codereview.chromium.org/147038/diff/1005/1007#newcode279
> Line 279: // Note that IsStringUTF8 checks not only if the input is
structrually
> Can you also put a "//" line above this one?
> 
> http://codereview.chromium.org/147038/diff/1005/1008
> File base/string_util_icu.cc (right):
> 
> http://codereview.chromium.org/147038/diff/1005/1008#newcode446
> Line 446: // Moreover, non-BMP characters in legacy multibyte encodings
> Blank line here?