Replace std:;wstring with std::string in locale-name related APIs....

Replace std:;wstring with std::string and string16 in locale-name related APIs.

1. Change the locale param to be std::string because they're always ASCII and change call-sites accordingly.
2. Add GetStringFUTF16 to l10n_util. On Windows, they're inline helpers calling the correspondingGetStringF returning wstring while on Mac/Linux, they just return the result of |string16 GetStringF|without converting to wstring.

This is part 1 of the fix for issue 8647. Some of newly introduced conversions are temporary and will be removed later (e.g. ASCIIToWide applied to the result of GetApplicationLocale in a few places). 

Note : this CL will be landed after http://codereview.chromium.org/147038 is landed. 
BUG=8647
(http://crbug.com/8647)
TEST=Pass l10n_util_unittest and other unit tests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19183

[Evan Stade, 2009-06-23 22:07:59]

lgtm for the files that end in gtk or linux

[brettw, 2009-06-23 22:35:14]

http://codereview.chromium.org/126223/diff/6001/7002
File app/l10n_util.h (right):

http://codereview.chromium.org/126223/diff/6001/7002#newcode76
Line 76: string16 GetStringFUTF16(int message_id,
Long term, we want to only have UTF-16 UI strings, and we will not want "UTF16"
suffixes. Why do we need the separate wstring versions when WCHAR_T_IS_UTF16.
The strings are the same so they can be casted, right?

I'd probably just call it GetStringUTF16 and define a wstring version only on
non-Windows that does the conversions necessary. When we convert everything this
can just go away.

http://codereview.chromium.org/126223/diff/6001/7002#newcode91
Line 91: inline std::wstring GetStringF(int message_id,
Check the alignment of all the wrapped args for these new functions.

[jungshik at Google, 2009-06-24 00:15:22]

http://codereview.chromium.org/126223/diff/6001/7002
File app/l10n_util.h (right):

http://codereview.chromium.org/126223/diff/6001/7002#newcode76
Line 76: string16 GetStringFUTF16(int message_id,
On 2009/06/23 22:35:15, brettw wrote:
> Long term, we want to only have UTF-16 UI strings, and we will not want
"UTF16"
> suffixes. Why do we need the separate wstring versions when WCHAR_T_IS_UTF16.

We have exactly the same long term goal :-) 

We need separate wstring versions for now (even on Windows) to ease the
transition.

For the moment, I added this as interim convenience functions because I don't
want to touch more files than included in this CL. (there are 61 caller, but
changing them all to use string16 for both input and return is a lot more
involved).

When all the callers move to UTF-16 (the input params are all converted to
UTF-16 as well) when/where it makes sense, we can strip away UTF-16 suffix kinda
mechanically in addition to getting rid of the current GetStringF (wstring
version). 


> The strings are the same so they can be casted, right?
> 
> I'd probably just call it GetStringUTF16 and define a wstring version only on
> non-Windows that does the conversions necessary. When we convert everything
this
> can just go away.
>

http://codereview.chromium.org/126223/diff/6001/7002#newcode91
Line 91: inline std::wstring GetStringF(int message_id,
On 2009/06/23 22:35:15, brettw wrote:
> Check the alignment of all the wrapped args for these new functions.

Done.

[brettw, 2009-06-24 00:28:54]

okay

[pink (ping after 24hrs), 2009-06-24 14:14:16]

*_mac LGTM

[tony, 2009-06-24 14:49:14]

LGTM, thanks a lot for doing this.

http://codereview.chromium.org/126223/diff/5122/4153
File base/file_util_icu.cc (right):

http://codereview.chromium.org/126223/diff/5122/4153#newcode75
Line 75: Singleton<IllegalCharacters> illegal_characters;
Should this be a LazyInstance?  Maybe do it as a follow up change.

http://codereview.chromium.org/126223/diff/5122/4139
File chrome/browser/autocomplete/autocomplete_edit_view_win.cc (right):

http://codereview.chromium.org/126223/diff/5122/4139#newcode1184
Line 1184: if (static_cast<int>(text.length()) >= GetTextLength()) {
Did you mean to include this file in the change list?