base/file_util_unittest.cc - Issue 147038: Pass through non-character codepoints in UTF-8,16,32 and Wide conversion func...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/file_util_unittest.cc

Issue 147038: Pass through non-character codepoints in UTF-8,16,32 and Wide conversion func... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 11 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/file_util_unittest.cc

===================================================================

--- base/file_util_unittest.cc (revision 19007)

+++ base/file_util_unittest.cc (working copy)

@@ -839,11 +839,9 @@

#if defined(OS_WIN)

{L"bad*file\\name.jpg", L"bad-file-name.jpg"},

{L"\t bad*file\\name/.jpg ", L"bad-file-name-.jpg"},

- {L"bad\uFFFFfile\U0010FFFEname.jpg ", L"bad-file-name.jpg"},

#elif defined(OS_POSIX)

{L"bad*file?name.jpg", L"bad-file-name.jpg"},

{L"\t bad*file?name/.jpg ", L"bad-file-name-.jpg"},

- {L"bad\uFFFFfile-name.jpg ", L"bad-file-name.jpg"},

#endif

{L"this_file_name is okay!.mp3", L"this_file_name is okay!.mp3"},

{L"\u4E00\uAC00.mp3", L"\u4E00\uAC00.mp3"},

@@ -851,6 +849,9 @@

{L"\U00010330\U00010331.mp3", L"\U00010330\U00010331.mp3"},

// Unassigned codepoints are ok.

{L"\u0378\U00040001.mp3", L"\u0378\U00040001.mp3"},

+ // Non-characters are not allowed.

+ {L"bad\uFFFFfile\U0010FFFEname.jpg ", L"bad-file-name.jpg"},

+ {L"bad\uFDD0file\uFDEFname.jpg ", L"bad-file-name.jpg"},

};

TEST_F(FileUtilTest, ReplaceIllegalCharactersTest) {

« no previous file with comments | « no previous file | base/string_util.h » ('j') | no next file with comments »