Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 141032: X64 implementation: Add high_bit() and low_bits() to register methods. (Closed)

Created:
11 years, 6 months ago by William Hesse
Modified:
9 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

X64 implementation: Add high_bit() and low_bits() to register methods. Committed: http://code.google.com/p/v8/source/detail?r=2231

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -36 lines) Patch
M src/x64/assembler-x64.h View 1 3 chunks +15 lines, -4 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 13 chunks +18 lines, -17 lines 0 comments Download
M src/x64/assembler-x64-inl.h View 1 5 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
William Hesse
11 years, 6 months ago (2009-06-21 13:55:13 UTC) #1
Lasse Reichstein
LGTM http://codereview.chromium.org/141032/diff/1/2 File src/x64/assembler-x64.cc (right): http://codereview.chromium.org/141032/diff/1/2#newcode1197 Line 1197: emit_rex_64(dst); If REX.W isn't required, we might ...
11 years, 6 months ago (2009-06-22 07:52:46 UTC) #2
William Hesse
11 years, 6 months ago (2009-06-22 08:18:32 UTC) #3
http://codereview.chromium.org/141032/diff/1/2
File src/x64/assembler-x64.cc (right):

http://codereview.chromium.org/141032/diff/1/2#newcode1197
Line 1197: emit_rex_64(dst);
On 2009/06/22 07:52:46, Lasse Reichstein wrote:
> If REX.W isn't required, we might as well use emit_optional_rex_32(dst)
> 

It is misleading to the code reader to read rex_32 for an actual 64-bit move. 
Actually, REX without REX.W may be diffrerent than no REX at all.

Powered by Google App Engine
This is Rietveld 408576698