Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 1387004: Avoid having a LIBS setting when compiling the V8 library... (Closed)

Created:
10 years, 9 months ago by Kasper Lund
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Avoid having a LIBS setting when compiling the V8 library because this interferes with the shared library build. Only prepend v8 to the LIBS list when building samples or cctest. Committed: http://code.google.com/p/v8/source/detail?r=4289

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M SConstruct View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kasper Lund
10 years, 9 months ago (2010-03-26 07:44:40 UTC) #1
Mads Ager (chromium)
10 years, 9 months ago (2010-03-26 07:46:50 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698