Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Side by Side Diff: SConstruct

Issue 1387004: Avoid having a LIBS setting when compiling the V8 library... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2008 the V8 project authors. All rights reserved. 1 # Copyright 2008 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 991 matching lines...) Expand 10 before | Expand all | Expand 10 after
1002 join('src', 'SConscript'), 1002 join('src', 'SConscript'),
1003 build_dir=join('obj', target_id), 1003 build_dir=join('obj', target_id),
1004 exports='context', 1004 exports='context',
1005 duplicate=False 1005 duplicate=False
1006 ) 1006 )
1007 1007
1008 context.mksnapshot_targets.append(mksnapshot) 1008 context.mksnapshot_targets.append(mksnapshot)
1009 1009
1010 # Link the object files into a library. 1010 # Link the object files into a library.
1011 env.Replace(**context.flags['v8']) 1011 env.Replace(**context.flags['v8'])
1012 env.Prepend(LIBS=[library_name])
1013 1012
1014 context.ApplyEnvOverrides(env) 1013 context.ApplyEnvOverrides(env)
1015 if context.options['library'] == 'static': 1014 if context.options['library'] == 'static':
1016 library = env.StaticLibrary(library_name, object_files) 1015 library = env.StaticLibrary(library_name, object_files)
1017 else: 1016 else:
1018 # There seems to be a glitch in the way scons decides where to put 1017 # There seems to be a glitch in the way scons decides where to put
1019 # PDB files when compiling using MSVC so we specify it manually. 1018 # PDB files when compiling using MSVC so we specify it manually.
1020 # This should not affect any other platforms. 1019 # This should not affect any other platforms.
1021 pdb_name = library_name + '.dll.pdb' 1020 pdb_name = library_name + '.dll.pdb'
1022 library = env.SharedLibrary(library_name, object_files, PDB=pdb_name) 1021 library = env.SharedLibrary(library_name, object_files, PDB=pdb_name)
(...skipping 14 matching lines...) Expand all
1037 join('samples', 'SConscript'), 1036 join('samples', 'SConscript'),
1038 build_dir=join('obj', 'sample', sample, target_id), 1037 build_dir=join('obj', 'sample', sample, target_id),
1039 exports='sample context', 1038 exports='sample context',
1040 duplicate=False 1039 duplicate=False
1041 ) 1040 )
1042 sample_name = sample + suffix 1041 sample_name = sample + suffix
1043 sample_program = sample_env.Program(sample_name, sample_object) 1042 sample_program = sample_env.Program(sample_name, sample_object)
1044 sample_env.Depends(sample_program, library) 1043 sample_env.Depends(sample_program, library)
1045 context.sample_targets.append(sample_program) 1044 context.sample_targets.append(sample_program)
1046 1045
1047 cctest_program = env.SConscript( 1046 cctest_env = env.Clone()
1047 cctest_env.Prepend(LIBS=[library_name])
1048 cctest_program = cctest_env.SConscript(
1048 join('test', 'cctest', 'SConscript'), 1049 join('test', 'cctest', 'SConscript'),
1049 build_dir=join('obj', 'test', target_id), 1050 build_dir=join('obj', 'test', target_id),
1050 exports='context object_files', 1051 exports='context object_files',
1051 duplicate=False 1052 duplicate=False
1052 ) 1053 )
1053 context.cctest_targets.append(cctest_program) 1054 context.cctest_targets.append(cctest_program)
1054 1055
1055 return context 1056 return context
1056 1057
1057 1058
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
1095 # version of scons. Also, there's a bug in some revisions that 1096 # version of scons. Also, there's a bug in some revisions that
1096 # doesn't allow this flag to be set, so we swallow any exceptions. 1097 # doesn't allow this flag to be set, so we swallow any exceptions.
1097 # Lovely. 1098 # Lovely.
1098 try: 1099 try:
1099 SetOption('warn', 'no-deprecated') 1100 SetOption('warn', 'no-deprecated')
1100 except: 1101 except:
1101 pass 1102 pass
1102 1103
1103 1104
1104 Build() 1105 Build()
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698