Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: SConstruct

Issue 1387004: Avoid having a LIBS setting when compiling the V8 library... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: SConstruct
===================================================================
--- SConstruct (revision 4288)
+++ SConstruct (working copy)
@@ -1009,7 +1009,6 @@
# Link the object files into a library.
env.Replace(**context.flags['v8'])
- env.Prepend(LIBS=[library_name])
context.ApplyEnvOverrides(env)
if context.options['library'] == 'static':
@@ -1044,7 +1043,9 @@
sample_env.Depends(sample_program, library)
context.sample_targets.append(sample_program)
- cctest_program = env.SConscript(
+ cctest_env = env.Clone()
+ cctest_env.Prepend(LIBS=[library_name])
+ cctest_program = cctest_env.SConscript(
join('test', 'cctest', 'SConscript'),
build_dir=join('obj', 'test', target_id),
exports='context object_files',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698