Re-attempt at http://codereview.chromium.org/1344002...

Re-attempt at http://codereview.chromium.org/1344002

Adds geolocaiton support to the location bar content image model and content bubble model.
Most of these edits were lifted out of http://codereview.chromium.org/650180

TODO: add geolocation support to the views in the three UI platforms for the bubble model.
(NOTE this change results in poorly formed bubble contents for the geolocaiton bubble, this will be fixed up in the following CLs)


BUG=11246
TEST=open a site that uses geolocaiton, select allow/deny & click the icon.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42739

[joth, 2010-03-25 22:20:55]

- only differences are DomainList now stores hosts as std::string instead of
GURL, to keep interface clean (and fixes unit test build brea), and includes
removing spurious string from generated_resources.grd

[joth, 2010-03-25 22:25:24]

Second attempt at updating the bubble model
should be just a rubber stamp: only differences are DomainList now stores hosts
as std::string instead of GURL, to keep interface clean (and fixes unit test
build break), and includes removing spurious string from generated_resources.grd
(forgot to include in previous change)

[Peter Kasting, 2010-03-25 22:28:37]

http://codereview.chromium.org/1369002/diff/1/6
File chrome/browser/content_setting_bubble_model.cc (right):

http://codereview.chromium.org/1369002/diff/1/6#newcode187
chrome/browser/content_setting_bubble_model.cc:187:
domains[it->second].hosts.push_back(it->first.spec());
I don't think you want spec() here.

I think in the bubble it's OK to omit schemes and collapse together e.g.
"http://foo.com" with "https://foo.com".  So what I think you want is host(),
and to use a set rather than a vector to hold these.

[joth, 2010-03-25 23:03:22]

On 2010/03/25 22:28:37, Peter Kasting wrote:
> http://codereview.chromium.org/1369002/diff/1/6
> File chrome/browser/content_setting_bubble_model.cc (right):
> 
> http://codereview.chromium.org/1369002/diff/1/6#newcode187
> chrome/browser/content_setting_bubble_model.cc:187:
> domains[it->second].hosts.push_back(it->first.spec());
> I don't think you want spec() here.
> 
> I think in the bubble it's OK to omit schemes and collapse together e.g.
> "http://foo.com" with "https://foo.com".  So what I think you want is host(),
> and to use a set rather than a vector to hold these.

This will collapse port numbers too, but for this list I think that is
reasonable as well, so changed as suggested.

Thanks! (I'll let try servers run and commit this until morning...)