First cut at implementing the windows geolocaiton bubble view....

First cut at implementing the windows geolocaiton bubble view.
Depends on http://codereview.chromium.org/1369002

BUG=11246
TEST=--enable-geolocation and open http://bulach-pc.lon/chromium/wk/LayoutTests/fast/dom/Window/mbi.html



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42749

[joth, 2010-03-26 00:06:21]

Just an FYI at this point -- Needs a bit of final polish in the morning, but its
close. If you have chance to give any tips on handling GridLayout with
word-wrapped content it would be well received :)

Joth

[Nico, 2010-03-26 00:07:42]

I'll try to get the mac bubble done until you wake up.

On Thu, Mar 25, 2010 at 5:06 PM,  <joth@chromium.org> wrote:
> Reviewers: Peter Kasting, bulach,
>
> Message:
> Just an FYI at this point -- Needs a bit of final polish in the morning, but
> its
> close. If you have chance to give any tips on handling GridLayout with
> word-wrapped content it would be well received :)
>
> Joth
>
>
> Description:
> First cut at implementing the windows geolocaiton bubble view.
> Depends on http://codereview.chromium.org/1369002
>
> BUG=11246
> TEST=--enable-geolocation and open
> http://bulach-pc.lon/chromium/wk/LayoutTests/fast/dom/Window/mbi.html
>
>
>
> Please review this at http://codereview.chromium.org/1348002
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/views/content_blocked_bubble_contents.h
>  M     chrome/browser/views/content_blocked_bubble_contents.cc
>
>
>

[Peter Kasting, 2010-03-26 00:13:51]

LGTM.  I don't know what types of problems you're having with layout but you
could perhaps ask sky about them.

http://codereview.chromium.org/1348002/diff/1/3
File chrome/browser/views/content_blocked_bubble_contents.cc (right):

http://codereview.chromium.org/1348002/diff/1/3#newcode182
chrome/browser/views/content_blocked_bubble_contents.cc:182: views::Label*
title_label = new views::Label(UTF8ToWide(
Nit: Breaking after = might be more readable

[joth, 2010-03-26 00:15:11]

On 2010/03/26 00:06:21, joth wrote:
> Just an FYI at this point -- Needs a bit of final polish in the morning, but
its
> close. If you have chance to give any tips on handling GridLayout with
> word-wrapped content it would be well received :)
> 
> Joth

[joth, 2010-03-26 00:15:55]

On 2010/03/26 00:15:11, joth wrote:
> On 2010/03/26 00:06:21, joth wrote:
> > Just an FYI at this point -- Needs a bit of final polish in the morning, but
> its
> > close. If you have chance to give any tips on handling GridLayout with
> > word-wrapped content it would be well received :)
> > 
> > Joth

For reference, the current state as of patch set 1 is shown in this window
capture: http://i.imgur.com/KK8GB.png