Issue 1317004: Stop abusing cookie strings for local storage and database.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1317004: Stop abusing cookie strings for local storage and database. (Closed)

Created:
10 years, 9 months ago by jorlow

Modified:
9 years, 6 months ago

Reviewers:
TVL

CC:
chromium-reviews, ben+cc_chromium.org

Visibility:
Public.

Description

Stop abusing cookie strings for local storage and database. We did the original abuse because we were past the 4.1 string freeze and needed to add new features, but we can fix this for chrome 5. TEST=The labels should be things like "Key:" instead of "Name:" and so on. BUG=34669 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42746

Patch Set 1 #

Patch Set 2 : s/DATABASE_NAME_LABEL/DATABASE_NAME/ #

Created: 10 years, 9 months ago

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -10 lines)
M	chrome/app/generated_resources.grd	View	1 chunk	+6 lines, -0 lines	0 comments
M	chrome/app/nibs/CookieDetailsView.xib	View	3 chunks	+3 lines, -3 lines	0 comments
M	chrome/browser/gtk/gtk_chrome_cookie_view.cc	View	2 chunks	+3 lines, -3 lines	0 comments
M	chrome/browser/views/database_open_info_view.cc	View	1 chunk	+1 line, -2 lines	0 comments
M	chrome/browser/views/local_storage_set_item_info_view.cc	View	1 chunk	+2 lines, -2 lines	0 comments

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

TVL

10 years, 9 months ago (2010-03-25 17:03:45 UTC) #2

lgtm

might want to throw os-all on the bug to make sure qa checks all platforms.

Expand Messages | Collapse Messages