Fix issue 5079: Incorrect "Active match ordinal" count during Find-in-page...

Fix issue 5079: Incorrect "Active match ordinal" count during Find-in-page

I introduced a regression in my reimplemenation of Find-in-page. The active match ordinal in Find-in-page (also known as "the 7" in "7 of 9") would be just a little off on pages with frames. 

Problem A: When you search for something in gmail, for example, the ordinal could start off slightly negative or be 0. I wasn't checking the last_match_count_ of a frame for negative numbers before adding it to the total (it starts off as -1 and remains that way if the frame is not deemed to be worthy of being scoped, i.e. if it is hidden).

Problem B: On pages with multiple matches spread across multiple frames the ordinal would not be subtracted correctly after pressing F3 and Shift-F3 to go back to the frame you were on. We shouldn't be increasing/decreasing the active_match_index for a given frame when FindNext/FindPrevious causes us to jump between frames. We should instead reset it.

I added two tests to catch this in the future. They test ordinal values as you use Find in page (including combinations of frames/no-frames & FindNext/FindPrevious).

Oh, and I also removed some traces that were supposed to expose why a test was flaky, but it turns out to have been something unrelated to the test.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6369

[idana, 2008-12-04 19:02:05]

LGTM (with a couple of nits)

Can you please make sure indernain verifies that the bug is fixed?

http://codereview.chromium.org/13130/diff/1/4
File chrome/test/automation/automation_messages_internal.h (right):

http://codereview.chromium.org/13130/diff/1/4#newcode314
Line 314: // NOTE: These two message have been deprecated, please use the new
messages
"These two message" -> "These two messages"

http://codereview.chromium.org/13130/diff/1/6
File chrome/test/automation/tab_proxy.h (right):

http://codereview.chromium.org/13130/diff/1/6#newcode183
Line 183: // "7 of 9". A return value of -1 indicates failure.
"7 of 9". -> "7 of 9").