Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3011)

Unified Diff: chrome/test/automation/tab_proxy.h

Issue 13130: Fix issue 5079: Incorrect "Active match ordinal" count during Find-in-page... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/automation/tab_proxy.h
===================================================================
--- chrome/test/automation/tab_proxy.h (revision 6273)
+++ chrome/test/automation/tab_proxy.h (working copy)
@@ -178,9 +178,11 @@
// specifies what string to search for, |forward| specifies whether to search
// in forward direction, and |match_case| specifies case sensitivity
// (true=case sensitive). |find_next| specifies whether this is a new search
- // or a continuation of the old one. A return value of -1 indicates failure.
+ // or a continuation of the old one. |ordinal| is an optional paramater that
+ // returns the ordinal of the active match (also known as "the 7" part of
+ // "7 of 9". A return value of -1 indicates failure.
idana 2008/12/04 19:02:05 "7 of 9". -> "7 of 9").
int FindInPage(const std::wstring& search_string, FindInPageDirection forward,
- FindInPageCase match_case, bool find_next);
+ FindInPageCase match_case, bool find_next, int* ordinal);
bool GetCookies(const GURL& url, std::string* cookies);
bool GetCookieByName(const GURL& url,

Powered by Google App Engine
This is Rietveld 408576698