Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3271)

Unified Diff: chrome/test/automation/automation_messages_internal.h

Issue 13130: Fix issue 5079: Incorrect "Active match ordinal" count during Find-in-page... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/automation/automation_messages_internal.h
===================================================================
--- chrome/test/automation/automation_messages_internal.h (revision 6273)
+++ chrome/test/automation/automation_messages_internal.h (working copy)
@@ -311,15 +311,15 @@
// (1=case sensitive, 0=case insensitive). If an error occurs, matches_found
// will be -1.
//
- // NOTE: This message has been deprecated, please use the new message
- // AutomationMsg_FindRequest below.
+ // NOTE: These two message have been deprecated, please use the new messages
idana 2008/12/04 19:02:05 "These two message" -> "These two messages"
+ // AutomationMsg_FindRequest and AutomationMsg_FindInPageResponse2 below.
//
- IPC_MESSAGE_ROUTED4(AutomationMsg_FindInPageRequest,
+ IPC_MESSAGE_ROUTED4(AutomationMsg_FindInPageRequest, // DEPRECATED.
int, /* tab_handle */
std::wstring, /* find_request */
int, /* forward */
int /* match_case */)
- IPC_MESSAGE_ROUTED1(AutomationMsg_FindInPageResponse,
+ IPC_MESSAGE_ROUTED1(AutomationMsg_FindInPageResponse, // DEPRECATED.
int /* matches_found */)
// This message sends a inspect element request for a given tab. The response
@@ -733,7 +733,7 @@
// This message starts a find within a tab corresponding to the supplied
// tab handle. The parameter |request| specifies what to search for.
// If an error occurs, |matches_found| will be -1 (see response message
- // AutomationMsg_FindInPageResponse).
+ // AutomationMsg_FindInPageResponse2).
//
IPC_MESSAGE_ROUTED2(AutomationMsg_FindRequest,
int, /* tab_handle */
@@ -807,4 +807,9 @@
IPC_MESSAGE_ROUTED1(AutomationMsg_ShowingAppModalDialogResponse,
bool /* showing dialog */)
+ // Returns the ordinal and the number of matches found as a response to
+ // a AutomationMsg_FindRequest.
+ IPC_MESSAGE_ROUTED2(AutomationMsg_FindInPageResponse2,
+ int /* active_ordinal */,
+ int /* matches_found */)
IPC_END_MESSAGES(Automation)

Powered by Google App Engine
This is Rietveld 408576698