Issue 131099: Clarify precedence of operations involving bitwise and(&) in x64/assembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 131099: Clarify precedence of operations involving bitwise and(&) in x64/assembler. (Closed)

Created:
11 years, 6 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Clarify precedence of operations involving bitwise and(&) in x64/assembler. Committed: http://code.google.com/p/v8/source/detail?r=2223

Patch Set 1 #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -3 lines)			Patch
M	AUTHORS	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/x64/assembler-x64.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/assembler-x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/assembler-x64-inl.h	View	1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

Fix precedence in expressions using &. Original patch by avassalotti@gmail.com, r=whesse@chromium.org, lrn@chromium.org. BUG=383

11 years, 6 months ago (2009-06-19 08:40:55 UTC) #1

Lasse Reichstein

11 years, 6 months ago (2009-06-19 09:03:20 UTC) #2

LGTM

http://codereview.chromium.org/131099/diff/1/5
File src/x64/assembler-x64-inl.h (right):

http://codereview.chromium.org/131099/diff/1/5#newcode126
Line 126: if (rm_reg.code() > 0x7) emit(0x41);
I've used  ">= 0x8" in other places. We really should have has_high_bit() on
Register.

Expand Messages | Collapse Messages