src/x64/assembler-x64-inl.h - Issue 131099: Clarify precedence of operations involving bitwise and(&) in x64/assembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/assembler-x64-inl.h

Issue 131099: Clarify precedence of operations involving bitwise and(&) in x64/assembler. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 11 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/assembler-x64-inl.h

===================================================================

--- src/x64/assembler-x64-inl.h (revision 2222)

+++ src/x64/assembler-x64-inl.h (working copy)

@@ -123,7 +123,7 @@

void Assembler::emit_optional_rex_32(Register rm_reg) {

- if (rm_reg.code() & 0x8 != 0) emit(0x41);

+ if (rm_reg.code() > 0x7) emit(0x41);

Lasse Reichstein 2009/06/19 09:03:24 I've used ">= 0x8" in other places. We really sho

}

« no previous file with comments | « src/x64/assembler-x64.cc ('k') | no next file » | no next file with comments »