Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(926)

Side by Side Diff: src/x64/assembler-x64.cc

Issue 131099: Clarify precedence of operations involving bitwise and(&) in x64/assembler. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1003 matching lines...) Expand 10 before | Expand all | Expand 10 after
1014 emit_operand(0, dst); 1014 emit_operand(0, dst);
1015 emit(value); 1015 emit(value);
1016 } 1016 }
1017 1017
1018 1018
1019 void Assembler::movq(Register dst, Handle<Object> value, RelocInfo::Mode mode) { 1019 void Assembler::movq(Register dst, Handle<Object> value, RelocInfo::Mode mode) {
1020 EnsureSpace ensure_space(this); 1020 EnsureSpace ensure_space(this);
1021 last_pc_ = pc_; 1021 last_pc_ = pc_;
1022 ASSERT(!Heap::InNewSpace(*value)); 1022 ASSERT(!Heap::InNewSpace(*value));
1023 emit_rex_64(dst); 1023 emit_rex_64(dst);
1024 emit(0xB8 | dst.code() & 0x7); 1024 emit(0xB8 | (dst.code() & 0x7));
1025 if (value->IsHeapObject()) { 1025 if (value->IsHeapObject()) {
1026 emitq(reinterpret_cast<uintptr_t>(value.location()), mode); 1026 emitq(reinterpret_cast<uintptr_t>(value.location()), mode);
1027 } else { 1027 } else {
1028 ASSERT_EQ(RelocInfo::NONE, mode); 1028 ASSERT_EQ(RelocInfo::NONE, mode);
1029 emitq(reinterpret_cast<uintptr_t>(*value), RelocInfo::NONE); 1029 emitq(reinterpret_cast<uintptr_t>(*value), RelocInfo::NONE);
1030 } 1030 }
1031 } 1031 }
1032 1032
1033 1033
1034 void Assembler::movsxlq(Register dst, Register src) { 1034 void Assembler::movsxlq(Register dst, Register src) {
(...skipping 858 matching lines...) Expand 10 before | Expand all | Expand 10 after
1893 void JumpTarget::DoBranch(Condition a, Hint b) { 1893 void JumpTarget::DoBranch(Condition a, Hint b) {
1894 UNIMPLEMENTED(); 1894 UNIMPLEMENTED();
1895 } 1895 }
1896 1896
1897 void JumpTarget::DoJump() { 1897 void JumpTarget::DoJump() {
1898 UNIMPLEMENTED(); 1898 UNIMPLEMENTED();
1899 } 1899 }
1900 1900
1901 1901
1902 } } // namespace v8::internal 1902 } } // namespace v8::internal
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698