Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 12895: Chromium-MultiProfile-Prototype... (Closed)

Created:
12 years ago by Munjal (Google)
Modified:
9 years ago
Reviewers:
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Chromium-MultiProfile-Prototype Summary ======= Implement a prototype of multiple profiles in Chrome by utilizing the functionality of user-data-dir command line flag that already exists. A profile in this case is an umbrella for all user data including cookies, history, bookmarks, settings, etc. Each profile gives the user a separation of all these data elements. User Interface ============== - Wrench > "New window in profile" menu item, with sub-menu items. This new menu item has sub menu items for each existing profile, for up to 9 profiles, and one more sub menu item to launch a window in a new profile. The 9 sub-menu items also have the accelerators like CTRL + SHIFT + 1, CTRL + SHIFT + 2, etc. If there are more than 9 profiles, we will also show an extra sub-menu item, "Other...". - New Profile dialog box This dialog box is shown to the use when (s)he clicks Wrench > New window in profile > <New Profile>. It lets the user specify a profile name, and also shows a checkbox to create a desktop shortcut to launch Chrome in that profile. - Choose profile dialog box This dialog box lets the user select a profile from a drop down to open a new window in. It also has an item <New Profile> in the drop down, selecting which will show the new profile dialog box mentioned above. CTRL + M shortcut also launches this dialog box. Code Organization ================= chrome\browser\user_data_dir_profile_manager.h/.cc: This class provides an abstraction of profiles on top of the user data dir command line flag. chrome\browser\views\user_data_dir_new_profile_dialog.h/.cc New profile dialog box code. chrome\browser\views\user_data_dir_profiles_dialog.h/.cc Choose profile dialog box code. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6333

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1378 lines, -19 lines) Patch
M chrome/app/chrome_dll.rc View 1 chunk +23 lines, -0 lines 0 comments Download
M chrome/app/chrome_dll_resource.h View 2 chunks +22 lines, -1 line 0 comments Download
M chrome/app/chromium_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 3 chunks +37 lines, -1 line 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/locales/locale_settings.h View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_ar.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_bg.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_bn.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_ca.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_cs.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_da.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_de.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_el.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_en-GB.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_en-US.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_es.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_es-419.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_et.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_fi.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_fil.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_fr.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_gu.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_he.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_hi.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_hr.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_hu.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_id.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_it.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_ja.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_kn.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_ko.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_lt.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_lv.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_ml.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_mr.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_nb.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_nl.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_or.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_pl.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_pt-BR.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_pt-PT.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_ro.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_ru.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_sk.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_sl.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_sr.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_sv.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_ta.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_te.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_th.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_tr.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_uk.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_vi.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_zh-CN.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_zh-TW.rc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/browser.h View 4 chunks +18 lines, -0 lines 0 comments Download
M chrome/browser/browser.cc View 4 chunks +46 lines, -1 line 0 comments Download
M chrome/browser/browser.vcproj View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/browser_main.cc View 4 chunks +29 lines, -0 lines 0 comments Download
M chrome/browser/browser_process.h View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/new_tab_ui.cc View 3 chunks +32 lines, -5 lines 0 comments Download
A chrome/browser/user_data_manager.h View 1 chunk +149 lines, -0 lines 0 comments Download
A chrome/browser/user_data_manager.cc View 1 chunk +298 lines, -0 lines 0 comments Download
M chrome/browser/views/browser_views.vcproj View 2 chunks +16 lines, -0 lines 0 comments Download
A chrome/browser/views/new_profile_dialog.h View 1 chunk +59 lines, -0 lines 0 comments Download
A chrome/browser/views/new_profile_dialog.cc View 1 chunk +105 lines, -0 lines 0 comments Download
A chrome/browser/views/select_profile_dialog.h View 1 chunk +85 lines, -0 lines 0 comments Download
A chrome/browser/views/select_profile_dialog.cc View 1 chunk +163 lines, -0 lines 0 comments Download
M chrome/browser/views/toolbar_view.h View 5 chunks +14 lines, -2 lines 0 comments Download
M chrome/browser/views/toolbar_view.cc View 7 chunks +64 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/views/message_box_view.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/views/message_box_view.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/views/window.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/views/window.cc View 1 chunk +18 lines, -8 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698