Issue 1225001: Add multiple item selection to BMM on mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1225001: Add multiple item selection to BMM on mac (Closed)

Created:
10 years, 9 months ago by feldstein

Modified:
9 years, 7 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Visibility:
Public.

Description

Add multiple item selection to BMM on mac BMM was originally only checking for the control key on non-mac platforms. BUG=39085 TEST=Select some non-contiguous bookmarks and copy and paste them, without the elements in between

Patch Set 1 #

Patch Set 2 : Handle on mouseDown on mac #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	chrome/browser/resources/bookmark_manager/js/cr/ui/listselectionmodel.js	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

LGTM On Mar 23, 2010 3:41 PM, <feldstein@chromium.org> wrote: uploaded new patch http://codereview.chromium.org/1225001

10 years, 9 months ago (2010-03-24 00:08:43 UTC) #3

feldstein

10 years, 9 months ago (2010-03-24 00:23:53 UTC) #4

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42411

Expand Messages | Collapse Messages