Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6900)

Unified Diff: chrome/browser/resources/bookmark_manager/js/cr/ui/listselectionmodel.js

Issue 1225001: Add multiple item selection to BMM on mac (Closed)
Patch Set: Handle on mouseDown on mac Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/bookmark_manager/js/cr/ui/listselectionmodel.js
diff --git a/chrome/browser/resources/bookmark_manager/js/cr/ui/listselectionmodel.js b/chrome/browser/resources/bookmark_manager/js/cr/ui/listselectionmodel.js
index 385c80f79c1dbccacbecf3bb826e3c0ed4649df3..70c261fcb91e8e1bd8731d69832774a408487dae 100644
--- a/chrome/browser/resources/bookmark_manager/js/cr/ui/listselectionmodel.js
+++ b/chrome/browser/resources/bookmark_manager/js/cr/ui/listselectionmodel.js
@@ -113,9 +113,9 @@ cr.define('cr.ui', function() {
this.clear();
} else {
var isDown = e.type == 'mousedown';
- if (!cr.isMac && e.ctrlKey) {
- // Handle ctrlKey on mouseup
- if (!isDown) {
+ if (cr.isMac ? e.metaKey : e.ctrlKey) {
+ // Selection is handled at mouseUp on windows/linux, mouseDown on mac.
+ if (cr.isMac? isDown : !isDown) {
// toggle the current one and make it anchor item
this.setItemSelected(item, !this.getItemSelected(item));
this.leadItem = item;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698