Issue 1216001: Look for ERROR too. Not sure if BAD actually ever shows up.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1216001: Look for ERROR too. Not sure if BAD actually ever shows up. (Closed)

Created:
10 years, 9 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
kmixter1

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

Look for ERROR too. Not sure if BAD actually ever shows up.

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/scripts/run_remote_tests.sh	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kmixter1

10 years, 9 months ago (2010-03-23 21:41:07 UTC) #2

LGTM

On Tue, Mar 23, 2010 at 2:31 PM,  <petkov@chromium.org> wrote:
> Reviewers: kmixter1,
>
> Description:
> Look for ERROR too. Not sure if BAD actually ever shows up.
>
> Please review this at http://codereview.chromium.org/1216001
>
> Affected files:
>  M src/scripts/run_remote_tests.sh
>
>
> Index: src/scripts/run_remote_tests.sh
> diff --git a/src/scripts/run_remote_tests.sh
> b/src/scripts/run_remote_tests.sh
> index
>
17cc32d1055d34eaac314935ec1aaf5c91a6e69f..b8e1992db55ecbcd456fba50e8c39a7e6731303c
> 100755
> --- a/src/scripts/run_remote_tests.sh
> +++ b/src/scripts/run_remote_tests.sh
> @@ -64,8 +64,8 @@ function cleanup() {
>  #   None
>  function is_successful_test() {
>   local file="$1"
> -  # To be successful, must not have FAIL or BAD in the file.
> -  if egrep -q "(BAD|FAIL)" "${file}"; then
> +  # To be successful, must not have BAD, ERROR or FAIL in the file.
> +  if egrep -q "(BAD|ERROR|FAIL)" "${file}"; then
>     return 1
>   fi
>   # To be successful, must have GOOD in the file.
>
>
>

Expand Messages | Collapse Messages