src/scripts/run_remote_tests.sh - Issue 1216001: Look for ERROR too. Not sure if BAD actually ever shows up.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/scripts/run_remote_tests.sh

Issue 1216001: Look for ERROR too. Not sure if BAD actually ever shows up. (Closed)

Patch Set: Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/scripts/run_remote_tests.sh

diff --git a/src/scripts/run_remote_tests.sh b/src/scripts/run_remote_tests.sh

index 17cc32d1055d34eaac314935ec1aaf5c91a6e69f..b8e1992db55ecbcd456fba50e8c39a7e6731303c 100755

--- a/src/scripts/run_remote_tests.sh

+++ b/src/scripts/run_remote_tests.sh

@@ -64,8 +64,8 @@ function cleanup() {

# None

function is_successful_test() {

local file="$1"

- # To be successful, must not have FAIL or BAD in the file.

- if egrep -q "(BAD|FAIL)" "${file}"; then

+ # To be successful, must not have BAD, ERROR or FAIL in the file.

+ if egrep -q "(BAD|ERROR|FAIL)" "${file}"; then

return 1

# To be successful, must have GOOD in the file.

« no previous file with comments | « no previous file | no next file » | no next file with comments »