make extension apis tolerate browser absence during start-up & shutdown

make extension apis tolerate browser absence during start-up & shutdown

Note: I was never able to directly reproduce the 13082 bug, the error mode is clear (there was no selected tab during a call to tabs.getSelected()). This fix will address that issue and we should stop seeing this crash reports.

R=erikkay
BUG=13082
Committed: http://src.chromium.org/viewvc/17631

[Erik does not do reviews, 2009-06-03 22:41:24]

http://codereview.chromium.org/119117/diff/1/3
File chrome/browser/extensions/extension_host.cc (right):

http://codereview.chromium.org/119117/diff/1/3#newcode199
Line 199: // into here before the browser is sufficiently initialized ot return
here.
ot -> to
add the TODO with the bug reference here
You may also want to mention the shutdown case.

http://codereview.chromium.org/119117/diff/1/4
File chrome/browser/extensions/extension_tabs_module.cc (right):

http://codereview.chromium.org/119117/diff/1/4#newcode165
Line 165: if (!browser)
set the error_ string

http://codereview.chromium.org/119117/diff/1/4#newcode173
Line 173: if (!browser)
set the error_ string

http://codereview.chromium.org/119117/diff/1/4#newcode350
Line 350: if (!browser)
set error_

http://codereview.chromium.org/119117/diff/1/4#newcode355
Line 355: if (!contents)
set error_

http://codereview.chromium.org/119117/diff/1/4#newcode372
Line 372: if (!browser)
set error_

http://codereview.chromium.org/119117/diff/1/4#newcode394
Line 394: if (!browser)
set error_

[rafaelw, 2009-06-03 23:40:25]

http://codereview.chromium.org/119117/diff/1/3
File chrome/browser/extensions/extension_host.cc (right):

http://codereview.chromium.org/119117/diff/1/3#newcode199
Line 199: // into here before the browser is sufficiently initialized ot return
here.
On 2009/06/03 22:41:24, Erik Kay wrote:
> ot -> to
> add the TODO with the bug reference here
> You may also want to mention the shutdown case.

Done.

http://codereview.chromium.org/119117/diff/1/4
File chrome/browser/extensions/extension_tabs_module.cc (right):

http://codereview.chromium.org/119117/diff/1/4#newcode165
Line 165: if (!browser)
On 2009/06/03 22:41:24, Erik Kay wrote:
> set the error_ string

Done.

http://codereview.chromium.org/119117/diff/1/4#newcode173
Line 173: if (!browser)
On 2009/06/03 22:41:24, Erik Kay wrote:
> set the error_ string

Done.

http://codereview.chromium.org/119117/diff/1/4#newcode350
Line 350: if (!browser)
On 2009/06/03 22:41:24, Erik Kay wrote:
> set error_

Done.

http://codereview.chromium.org/119117/diff/1/4#newcode355
Line 355: if (!contents)
On 2009/06/03 22:41:24, Erik Kay wrote:
> set error_

Done.

http://codereview.chromium.org/119117/diff/1/4#newcode372
Line 372: if (!browser)
On 2009/06/03 22:41:24, Erik Kay wrote:
> set error_

Done.

http://codereview.chromium.org/119117/diff/1/4#newcode394
Line 394: if (!browser)
On 2009/06/03 22:41:24, Erik Kay wrote:
> set error_

Done.

[Erik does not do reviews, 2009-06-03 23:44:15]

LGTM