Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1605)

Unified Diff: chrome/browser/extensions/extension_function_dispatcher.cc

Issue 119117: make extension apis tolerate browser absence during start-up & shutdown (Closed)
Patch Set: CR changes Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_function_dispatcher.cc
diff --git a/chrome/browser/extensions/extension_function_dispatcher.cc b/chrome/browser/extensions/extension_function_dispatcher.cc
index dc5c8f13eca8eaa58c30887d1aeaa60608e3ca79..93a34db8dc5288bf8b273b6d1e67d0219351dc66 100644
--- a/chrome/browser/extensions/extension_function_dispatcher.cc
+++ b/chrome/browser/extensions/extension_function_dispatcher.cc
@@ -68,7 +68,7 @@ void FactoryRegistry::ResetFunctions() {
namespace bookmarks = extension_bookmarks_module_constants;
// Windows
- factories_[tabs::kGetWindowFunction] =
+ factories_[tabs::kGetWindowFunction] =
&NewExtensionFunction<GetWindowFunction>;
factories_[tabs::kGetCurrentWindowFunction] =
&NewExtensionFunction<GetCurrentWindowFunction>;
@@ -76,27 +76,27 @@ void FactoryRegistry::ResetFunctions() {
&NewExtensionFunction<GetLastFocusedWindowFunction>;
factories_[tabs::kGetAllWindowsFunction] =
&NewExtensionFunction<GetAllWindowsFunction>;
- factories_[tabs::kCreateWindowFunction] =
+ factories_[tabs::kCreateWindowFunction] =
&NewExtensionFunction<CreateWindowFunction>;
- factories_[tabs::kUpdateWindowFunction] =
+ factories_[tabs::kUpdateWindowFunction] =
&NewExtensionFunction<UpdateWindowFunction>;
- factories_[tabs::kRemoveWindowFunction] =
+ factories_[tabs::kRemoveWindowFunction] =
&NewExtensionFunction<RemoveWindowFunction>;
// Tabs
- factories_[tabs::kGetTabFunction] =
+ factories_[tabs::kGetTabFunction] =
&NewExtensionFunction<GetTabFunction>;
factories_[tabs::kGetSelectedTabFunction] =
&NewExtensionFunction<GetSelectedTabFunction>;
factories_[tabs::kGetAllTabsInWindowFunction] =
&NewExtensionFunction<GetAllTabsInWindowFunction>;
- factories_[tabs::kCreateTabFunction] =
+ factories_[tabs::kCreateTabFunction] =
&NewExtensionFunction<CreateTabFunction>;
- factories_[tabs::kUpdateTabFunction] =
+ factories_[tabs::kUpdateTabFunction] =
&NewExtensionFunction<UpdateTabFunction>;
- factories_[tabs::kMoveTabFunction] =
+ factories_[tabs::kMoveTabFunction] =
&NewExtensionFunction<MoveTabFunction>;
- factories_[tabs::kRemoveTabFunction] =
+ factories_[tabs::kRemoveTabFunction] =
&NewExtensionFunction<RemoveTabFunction>;
// Page Actions.
@@ -185,7 +185,6 @@ Browser* ExtensionFunctionDispatcher::GetBrowser() {
DCHECK(delegate_);
Browser* retval = delegate_->GetBrowser();
- DCHECK(retval);
return retval;
}
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698