make extension apis tolerate browser absence during start-up & shutdown

chrome/browser/extensions/extension_function_dispatcher.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_function_dispatcher.h"
 
 #include "base/process_util.h"
 #include "base/singleton.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/extension_bookmarks_module.h"
@@ skipping 50 matching lines @@
 }
 
 void FactoryRegistry::ResetFunctions() {
   // Register all functions here.
 
   namespace tabs = extension_tabs_module_constants;
   namespace page_actions = extension_page_actions_module_constants;
   namespace bookmarks = extension_bookmarks_module_constants;
 
   // Windows
-  factories_[tabs::kGetWindowFunction] = 
+  factories_[tabs::kGetWindowFunction] =
       &NewExtensionFunction<GetWindowFunction>;
   factories_[tabs::kGetCurrentWindowFunction] =
       &NewExtensionFunction<GetCurrentWindowFunction>;
   factories_[tabs::kGetLastFocusedWindowFunction] =
       &NewExtensionFunction<GetLastFocusedWindowFunction>;
   factories_[tabs::kGetAllWindowsFunction] =
       &NewExtensionFunction<GetAllWindowsFunction>;
-  factories_[tabs::kCreateWindowFunction] = 
+  factories_[tabs::kCreateWindowFunction] =
       &NewExtensionFunction<CreateWindowFunction>;
-  factories_[tabs::kUpdateWindowFunction] = 
+  factories_[tabs::kUpdateWindowFunction] =
       &NewExtensionFunction<UpdateWindowFunction>;
-  factories_[tabs::kRemoveWindowFunction] = 
+  factories_[tabs::kRemoveWindowFunction] =
       &NewExtensionFunction<RemoveWindowFunction>;
 
   // Tabs
-  factories_[tabs::kGetTabFunction] = 
+  factories_[tabs::kGetTabFunction] =
       &NewExtensionFunction<GetTabFunction>;
   factories_[tabs::kGetSelectedTabFunction] =
       &NewExtensionFunction<GetSelectedTabFunction>;
   factories_[tabs::kGetAllTabsInWindowFunction] =
       &NewExtensionFunction<GetAllTabsInWindowFunction>;
-  factories_[tabs::kCreateTabFunction] = 
+  factories_[tabs::kCreateTabFunction] =
       &NewExtensionFunction<CreateTabFunction>;
-  factories_[tabs::kUpdateTabFunction] = 
+  factories_[tabs::kUpdateTabFunction] =
       &NewExtensionFunction<UpdateTabFunction>;
-  factories_[tabs::kMoveTabFunction] = 
+  factories_[tabs::kMoveTabFunction] =
       &NewExtensionFunction<MoveTabFunction>;
-  factories_[tabs::kRemoveTabFunction] = 
+  factories_[tabs::kRemoveTabFunction] =
       &NewExtensionFunction<RemoveTabFunction>;
 
   // Page Actions.
   factories_[page_actions::kEnablePageActionFunction] =
       &NewExtensionFunction<EnablePageActionFunction>;
 
   // Bookmarks.
   factories_[bookmarks::kGetBookmarksFunction] =
       &NewExtensionFunction<GetBookmarksFunction>;
   factories_[bookmarks::kGetBookmarkChildrenFunction] =
@@ skipping 68 matching lines @@
       ExtensionMessageService::GetInstance(profile()->GetRequestContext());
   DCHECK(process);
   DCHECK(message_service);
   message_service->RegisterExtension(extension_id, process->pid());
 }
 
 Browser* ExtensionFunctionDispatcher::GetBrowser() {
   DCHECK(delegate_);
 
   Browser* retval = delegate_->GetBrowser();
-  DCHECK(retval);
   return retval;
 }
 
 void ExtensionFunctionDispatcher::HandleRequest(const std::string& name,
                                                 const std::string& args,
                                                 int request_id,
                                                 bool has_callback) {
   // TODO(aa): This will get a bit more complicated when we support functions
   // that live longer than the stack frame.
   scoped_ptr<ExtensionFunction> function(
@@ skipping 20 matching lines @@
   } else {
     NOTREACHED();
     base::KillProcess(render_view_host_->process()->process().handle(),
                       ResultCodes::KILLED_BAD_MESSAGE, false);
   }
 }
 
 Profile* ExtensionFunctionDispatcher::profile() {
   return render_view_host_->process()->profile();
 }