Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 118500: Get rid of the notion of "parameter pointer" that no longer exists in... (Closed)

Created:
11 years, 6 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Get rid of the notion of "parameter pointer" that no longer exists in the implementation but still lives on in comments and identifier names. Where it was used, it has been changed to "caller's stack pointer". Committed: http://code.google.com/p/v8/source/detail?r=2137

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -58 lines) Patch
M src/arm/codegen-arm.cc View 5 chunks +6 lines, -9 lines 0 comments Download
M src/arm/frames-arm.h View 3 chunks +7 lines, -7 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M src/frames.h View 3 chunks +2 lines, -3 lines 0 comments Download
M src/frames.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M src/frames-inl.h View 2 chunks +2 lines, -7 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M src/ia32/frames-ia32.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/frames-x64.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
11 years, 6 months ago (2009-06-10 14:07:03 UTC) #1
Kasper Lund
11 years, 6 months ago (2009-06-10 14:10:57 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698