src/ia32/codegen-ia32.cc - Issue 118500: Get rid of the notion of "parameter pointer" that no longer exists in...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/codegen-ia32.cc

Issue 118500: Get rid of the notion of "parameter pointer" that no longer exists in... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 11 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/codegen-ia32.cc

===================================================================

--- src/ia32/codegen-ia32.cc (revision 2135)

+++ src/ia32/codegen-ia32.cc (working copy)

@@ -7118,12 +7118,11 @@

// ebp: frame pointer (restored after C call)

// esp: stack pointer (restored after C call)

// esi: current context (C callee-saved)

- // edi: caller's parameter pointer pp (C callee-saved)

+ // edi: JS function of the caller (C callee-saved)

- // NOTE: Invocations of builtins may return failure objects

- // instead of a proper result. The builtin entry handles

- // this by performing a garbage collection and retrying the

- // builtin once.

+ // NOTE: Invocations of builtins may return failure objects instead

+ // of a proper result. The builtin entry handles this by performing

+ // a garbage collection and retrying the builtin (twice).

StackFrame::Type frame_type = is_debug_break ?

StackFrame::EXIT_DEBUG :

« no previous file with comments | « src/frames-inl.h ('k') | src/ia32/frames-ia32.h » ('j') | no next file with comments »