Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Issue 118380: Add statistics operations and long calls and jumps to x64 macro assembler. (Closed)

Created:
11 years, 6 months ago by William Hesse
Modified:
9 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Add statistics operations and long calls and jumps to x64 macro assembler. Remove unimplemented instructions from x64 assembler. Add operand-size suffixes to add, sub, inc, dec, and cmp. Committed: http://code.google.com/p/v8/source/detail?r=2139

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -91 lines) Patch
M src/x64/assembler-x64.h View 1 2 13 chunks +48 lines, -56 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 2 12 chunks +79 lines, -13 lines 0 comments Download
M src/x64/builtins-x64.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/x64/codegen-x64.cc View 2 8 chunks +8 lines, -8 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 2 5 chunks +68 lines, -3 lines 0 comments Download
M test/cctest/test-assembler-x64.cc View 2 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
William Hesse
Should we change all the add and sub operations to addq and subq because we ...
11 years, 6 months ago (2009-06-08 12:16:15 UTC) #1
Lasse Reichstein
If we have both addl and add, we should rename add to addq. However, there ...
11 years, 6 months ago (2009-06-09 07:14:45 UTC) #2
William Hesse
I renamed the add, sub, inc, and dec operations, adding operand-size suffixes. I removed unused ...
11 years, 6 months ago (2009-06-09 08:47:07 UTC) #3
Lasse Reichstein
11 years, 6 months ago (2009-06-09 10:30:15 UTC) #4
Still LGTM.

Powered by Google App Engine
This is Rietveld 408576698