Issue 118219: Reland my ClientSocketPool refactor again...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 118219: Reland my ClientSocketPool refactor again... (Closed)

Created:
11 years, 6 months ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
wtc

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Reland my ClientSocketPool refactor again... The bug was that the handle was getting reused, so the ConnectingSocket doesn't know that it got canceled. It just keeps chugging away. I added a map to keep track of the ConnectingSockets so they can be canceled if we detect a reuse. TBR=wtc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17606

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+901 lines, -377 lines)			Patch
M	base/stl_util-inl.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	net/base/client_socket_handle.h	View	2 chunks	+36 lines, -18 lines	0 comments	Download
M	net/base/client_socket_handle.cc	View	1 chunk	+42 lines, -9 lines	0 comments	Download
M	net/base/client_socket_pool.h	View	7 chunks	+101 lines, -32 lines	0 comments	Download
M	net/base/client_socket_pool.cc	View	9 chunks	+262 lines, -33 lines	0 comments	Download
M	net/base/client_socket_pool_unittest.cc	View	8 chunks	+276 lines, -88 lines	0 comments	Download
M	net/base/test_completion_callback.h	View	2 chunks	+1 line, -1 line	0 comments	Download
M	net/http/http_network_layer.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	net/http/http_network_session.h	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	net/http/http_network_transaction.h	View	4 chunks	+24 lines, -27 lines	0 comments	Download
M	net/http/http_network_transaction.cc	View	12 chunks	+31 lines, -103 lines	0 comments	Download
M	net/http/http_network_transaction_unittest.cc	View	37 chunks	+114 lines, -63 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

Got it to stick this time with some messiness. I'll clean it up tomorrow. Note ...

11 years, 6 months ago (2009-06-04 07:13:19 UTC) #1

wtc

11 years, 6 months ago (2009-06-04 17:02:20 UTC) #2

LGTM.

With all the reverting and relanding, it's hard to see
the diffs between them because they are separate CLs.
I think the best way to review the code is for someone to
review the new client_socket_handle and client_socket_pool
code carefully.  I didn't have time to do that.  Perhaps we
can ask Eric Roman to review those four files.

Your changes to http_network_transaction are quite
straightforward.

Expand Messages | Collapse Messages