Issue 118024: Properly display mnemonics in some gtk menus where they were not being escape...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 118024: Properly display mnemonics in some gtk menus where they were not being escape... (Closed)

Created:
11 years, 6 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Properly display mnemonics in some gtk menus where they were not being escaped and showed up as &. Get rid of manual escaping in bookmark context menu gtk. BUG=12868 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17228

Patch Set 1 #

Patch Set 2 : comply with erg request #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -15 lines)			Patch
	M	chrome/browser/bookmarks/bookmark_context_menu_gtk.cc	View		2 chunks	+3 lines, -12 lines	0 comments	Download
	M	chrome/browser/gtk/menu_gtk.cc	View	1	3 chunks	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

Could you also remove the instances from bookmark_context_menu_gtk.cc where ConvertAcceleratorsFromWindowsStyle() was being called manually before ...

11 years, 6 months ago (2009-05-29 20:19:36 UTC) #2

Evan Stade

11 years, 6 months ago (2009-05-29 20:27:51 UTC) #3

On 2009/05/29 20:19:36, Elliot Glaysher wrote:
> Could you also remove the instances from bookmark_context_menu_gtk.cc where
> ConvertAcceleratorsFromWindowsStyle() was being called manually before
> MenuGtk::AppendWhatever()?

okely dokely

> 
> (Otherwise, LGTM).

Expand Messages | Collapse Messages